Describe your environment
Ubuntu 20.04
x86_64
Python 3.10.9
Steps to reproduce
I'll post a PR that addresses the issue with a test that reproduces the problem shortly.
This problem can be triggered by running the grpc instrumentation and utilizing Unix sockets for connections.
server.add_insecure_port("unix:///tmp/grpc.sock")
channel = grpc.insecure_channel("unix:///tmp/grpc.sock")
What is the expected behavior?
The grpc instrumentation should collect traces when running on a Unix socket.
What is the actual behavior?
A ValueError is thrown here:
https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py#L254-L256
context.peer() is unix: which results in ip, port = [""].
Describe your environment
Steps to reproduce
I'll post a PR that addresses the issue with a test that reproduces the problem shortly.
This problem can be triggered by running the
grpcinstrumentation and utilizing Unix sockets for connections.What is the expected behavior?
The
grpcinstrumentation should collect traces when running on a Unix socket.What is the actual behavior?
A
ValueErroris thrown here:https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py#L254-L256
context.peer()isunix:which results inip, port = [""].