For anyone picking this up (as I've been reviewing the same issue in the Java implementation) -

The problem in Python land is in the handling of grpc.RpcError when it gets thrown:
https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py#L154

https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py#L212

As per the upstream docs, anything that doesn't return OK will throw RpcError():
https://grpc.github.io/grpc/python/grpc.html#grpc-exceptions

However, rather than just treating that as an error, as the code currently does, we need to be checking the status first, and then decide if that status is actually one we should mark the span as error or not (e.g. NOT_FOUND should not mark the span as an error).

Update gRPC server status code to span status code mapping #1756

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions