opentelemetry-exporter-http-transport: enable entry-point loading of transport implementations#5320
Merged
aabmass merged 10 commits intoJun 24, 2026
Merged
Conversation
…transport implementations
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a mechanism for discovering HTTP transport implementations via the opentelemetry_http_transport entry-point group, and introduces a new BaseHTTPTransport.create() factory API with corresponding tests for the built-in requests and urllib3 transports.
Changes:
- Add
_load_http_transport_class()that resolves transports by name, falling back to entry-point discovery for non-built-in transports. - Introduce a
BaseHTTPTransport.create()classmethod and implement it forRequestsHTTPTransportandUrllib3HTTPTransport. - Register built-in transports as
opentelemetry_http_transportentry points and expand test coverage around loading and factory behavior.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Adds opentelemetry-api dependency metadata for the transport package in the lockfile. |
| exporter/opentelemetry-exporter-http-transport/pyproject.toml | Adds opentelemetry-api dependency and registers transport entry points. |
| exporter/opentelemetry-exporter-http-transport/src/opentelemetry/exporter/http/transport/init.py | Implements transport-class loading with built-in fast-path + entry-point fallback. |
| exporter/opentelemetry-exporter-http-transport/src/opentelemetry/exporter/http/transport/_base.py | Adds the new BaseHTTPTransport.create() API. |
| exporter/opentelemetry-exporter-http-transport/src/opentelemetry/exporter/http/transport/_requests.py | Implements RequestsHTTPTransport.create(). |
| exporter/opentelemetry-exporter-http-transport/src/opentelemetry/exporter/http/transport/_urllib3.py | Implements Urllib3HTTPTransport.create(). |
| exporter/opentelemetry-exporter-http-transport/tests/test_load_transport.py | Adds tests for built-in vs entry-point transport loading behavior. |
| exporter/opentelemetry-exporter-http-transport/tests/test_requests_transport.py | Adds tests validating RequestsHTTPTransport.create() behavior. |
| exporter/opentelemetry-exporter-http-transport/tests/test_urllib3_transport.py | Adds tests validating Urllib3HTTPTransport.create() behavior. |
| exporter/opentelemetry-exporter-http-transport/test-requirements.in | Ensures opentelemetry-api is installed for tests. |
| exporter/opentelemetry-exporter-http-transport/test-requirements.latest.txt | Reflects updated test dependency resolution including opentelemetry-api. |
| exporter/opentelemetry-exporter-http-transport/test-requirements.oldest.txt | Reflects updated lowest-version test dependency resolution including opentelemetry-api. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@herin049 looks like the last paragraph of the PR description is missing some content |
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
Member
There was a problem hiding this comment.
Overall looks good. I've left some suggestions / queries.
xrmx
approved these changes
Jun 19, 2026
Contributor
|
@herin049 please fix typechecking |
xrmx
moved this from Ready for review
to Approved PRs that need fixes
in Python PR digest
herin049
moved this from Approved PRs that need fixes
to Approved PRs
in Python PR digest
xrmx
approved these changes
Jun 22, 2026
aabmass
reviewed
Jun 22, 2026
aabmass
approved these changes
Jun 23, 2026
Member
|
Turned on automerge, just need to resolve comments |
aabmass
enabled auto-merge
June 23, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes enables entry-point loading of HTTP transport implementations via the
opentelemetry_http_transportentry-point. Furthermore, this PR adds an abstract classmethodcreate()to support instantiation of transport classes loaded via the entry-point loading mechanism introduced in this PR. The motivation for these changes is to provide a low friction strategy for users to provide their own transport implementations.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: