opentelemetry-sdk: add 'force_flush' method to LogRecordExporter ABC#5294
Merged
Conversation
ocelotl
suggested changes
Jun 24, 2026
ocelotl
left a comment
ocelotl
left a comment
Contributor
There was a problem hiding this comment.
Please review the type and value of the timeout, besides that, I am ready to approve ✌️ .
github-project-automation
Bot
moved this to Reviewed PRs that need fixes
in Python PR digest
lmolkova
approved these changes
Jun 25, 2026
ocelotl
approved these changes
Jun 27, 2026
xrmx
approved these changes
Jul 10, 2026
github-project-automation
Bot
moved this from Reviewed PRs that need fixes
to Approved PRs
in Python PR digest
carlosalberto
approved these changes
Jul 10, 2026
tammy-baylis-swi
approved these changes
Jul 10, 2026
Contributor
|
#5403 created as a follow up, so this PR doesn't get stuck. |
lzchen
approved these changes
Jul 13, 2026
lzchen
left a comment
lzchen
left a comment
Contributor
There was a problem hiding this comment.
This will cause previous child implementations to require the new method but I think this is fine to enforce.
github-project-automation
Bot
moved this from In Progress
to Done
in Python Logging API/SDK RC
Eason09053360
added a commit
to Eason09053360/opentelemetry-python
that referenced
this pull request
Jul 14, 2026
…pen-telemetry#5294) * opentelemetry-sdk: add 'force_flush' method to LogRecordExporter ABC * update unit tests * update 'force_flush' doc-string * add changelog fragment * switch timeout millis from float to int * update remaining type hints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5359
Description
The OpenTelemetry SDK specification for logs documents the force flush operation, but this function is currently not required for log exporter implementation. This PR addresses this by adding
force_flushto theLogRecordExporterABC.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: