Remove Events API/SDK#5293
Conversation
|
You may want to decorate the no-op shims with |
These were deprecated a few versions back. We need to now remove them. Hence, we are not decorating them. Is that what you were referring to? |
My bad, looks like they're just test functions, nothing part of the public api. LGTM |
ce77b58 to
d157ebe
Compare
1ecaaef to
832323d
Compare
342f4b7 to
0e75aa3
Compare
|
(Symbolic approval - right direction to align the implementation with the Specification) |
|
@rads-1996 this PR has many approvals, can you fix the CI issues so that it can be merged, please? |
@ocelotl The checks are green now. Could you please help merge the PR. Thanks! |
|
@rads-1996 I would smash that green button if I could, but I don't have the permissions. @open-telemetry/python-maintainers please help us here ✌️ |
Automated update of OpenTelemetry dependencies. **Build Status:** ❌ [failure](https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/29554721211) **Updated versions:** - [OpenTelemetry Python](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.44.0): 1.44.0 - [OpenTelemetry Contrib](https://github.com/open-telemetry/opentelemetry-python-contrib/releases/tag/v0.65b0): 0.65b0 - [opentelemetry-sdk-extension-aws](https://pypi.org/project/opentelemetry-sdk-extension-aws/2.1.0/): 2.1.0 - [opentelemetry-propagator-aws-xray](https://pypi.org/project/opentelemetry-propagator-aws-xray/1.0.2/): 1.0.2 - [opentelemetry-instrumentation-openai-agents-v2](https://pypi.org/project/opentelemetry-instrumentation-openai-agents-v2/0.1.0/): 0.1.0 **Upstream releases with breaking changes:** Note: the mechanism to detect upstream breaking changes is not perfect. Be sure to check all new releases and understand if any additional changes need to be addressed. **opentelemetry-python:** - [Version 1.44.0/0.65b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.44.0) **opentelemetry-python-contrib:** - [Version 1.44.0/0.65b0](https://github.com/open-telemetry/opentelemetry-python-contrib/releases/tag/v0.65b0) *Description of changes:* - Drops the `opentelemetry-instrumentation-elasticsearch` runtime dependency (from `pyproject.toml`, the lite-mode instrumentor map, and the nightly bot's `CONTRIB_DEPS` allowlist), removed entirely upstream now that all supported `elasticsearch` versions ship native OTel instrumentation: open-telemetry/opentelemetry-python-contrib#4759 - Migrates the three Events API call sites (`llo_handler.py`, `debugger/_snapshot_otlp_emitter.py`, `aws_opentelemetry_configurator._init_logging`) to emit `LogRecord` with the `event_name` field via the Logs API, after upstream removed the deprecated Events API/SDK (`opentelemetry._events` / `opentelemetry.sdk._events`): open-telemetry/opentelemetry-python#5293 To keep the OTLP wire shape byte-identical to v0.18.0 for downstream consumers, the migration explicitly preserves the two things the old `Event` class auto-injected: the `event.name` attribute (which the GenAI E2E `CWLogValidator` asserts on) and `severity_number=INFO`. Verified by encoding both versions' output through the OTLP proto encoder and diffing — the only deltas are the additive top-level `eventName` field and SDK-generated resource metadata (`telemetry.sdk.version`, `service.instance.id`). - Implements `force_flush` on `CompactConsoleLogRecordExporter`, required after upstream added it as an abstract method on the `LogRecordExporter` ABC (instantiation otherwise fails with `TypeError`): open-telemetry/opentelemetry-python#5294 --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Eric Zhang <[email protected]> Co-authored-by: Steve Liu <[email protected]>
Description
Address issue #4655
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: