opentelemetry-sdk: remove generator in the accessor for links/events#5287
Merged
Conversation
A small performance improvement that doesn't impact anything else. The results from running the trace benchmarks with the added tests show a median improvement over 10 runs: ``` | Test | Before (ns) | After (ns) | Improvement | |---|---|---|---| | `test_read_events[1]` | 6,351.2 | 6,029.5 | +5.1% | | `test_read_events[10]` | 17,303.1 | 16,521.3 | +4.5% | | `test_read_events[50]` | 64,633.7 | 61,815.9 | +4.4% | | `test_read_events[128]` | 155,636.7 | 149,841.7 | +3.7% | | `test_read_links[1]` | 5,866.8 | 5,464.1 | +6.9% | | `test_read_links[10]` | 12,995.7 | 12,350.7 | +5.0% | | `test_read_links[50]` | 43,593.6 | 42,135.1 | +3.3% | | `test_read_links[128]` | 106,932.7 | 99,705.2 | +6.8% | ``` Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
herin049
approved these changes
Jun 10, 2026
7 tasks
Signed-off-by: Alex Boten <[email protected]>
MikeGoldsmith
approved these changes
Jun 11, 2026
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
Member
There was a problem hiding this comment.
Amazing - thanks @codeboten!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small performance improvement that doesn't impact anything else.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The results from running the trace benchmarks with the added tests show a median improvement over 10 runs:
test_read_events[1]test_read_events[10]test_read_events[50]test_read_events[128]test_read_links[1]test_read_links[10]test_read_links[50]test_read_links[128]Checklist: