Skip to content

Bump bundled opentelemetry-proto to v1.10.0 and regenerate#5223

Merged
aabmass merged 2 commits into
open-telemetry:mainfrom
pydantic:bump-otlp-proto-v1.10.0
May 20, 2026
Merged

Bump bundled opentelemetry-proto to v1.10.0 and regenerate#5223
aabmass merged 2 commits into
open-telemetry:mainfrom
pydantic:bump-otlp-proto-v1.10.0

Conversation

@adriangb

@adriangb adriangb commented May 18, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps the bundled proto definitions from opentelemetry-proto v1.9.0 to
v1.10.0 and regenerates the *_pb2.py / *_pb2.pyi files via
scripts/proto_codegen.sh (only PROTO_REPO_BRANCH_OR_COMMIT was edited; no
manual edits to generated files).

The motivating change is in the v1development profiles signal. Between
proto v1.9.0 and v1.10.0 the Sample message field numbers were
renumbered to group the identity fields first:

field v1.9.0 (currently bundled) v1.10.0
stack_index 1 1
attribute_indices 3 2
link_index 4 3
values 2 4
timestamps_unix_nano 5 5

Because the bundled snapshot still uses the old numbering, a Sample
serialized via opentelemetry-proto is wire-incompatible with OTLP profiles
consumers built against current proto (e.g. Grafana Pyroscope 2.x): values
is decoded as attribute_indices and the profile is silently dropped.

The bump also pulls in two unrelated v1.10.0 changes:

  • common/v1: AnyValue gains string_value_strindex and KeyValue gains
    key_strindex (development, profiling-oriented string-table references).
  • logs/v1: a doc comment was dropped from SEVERITY_NUMBER_UNSPECIFIED
    (.pyi only, no wire change).

Traces and metrics protos are unchanged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

scripts/proto_codegen.sh runs cleanly and regenerates the bindings. The
renumbered Sample descriptor was verified to round-trip against a current
OTLP profiles consumer.

🤖 Generated with Claude Code

@adriangb
adriangb requested a review from a team as a code owner May 18, 2026 20:34
@linux-foundation-easycla

linux-foundation-easycla Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: adriangb / name: Adrian Garcia Badaracco (33ea2bc)

@adriangb
adriangb force-pushed the bump-otlp-proto-v1.10.0 branch 2 times, most recently from 8644435 to fa4f9b6 Compare May 18, 2026 20:42
@adriangb adriangb mentioned this pull request May 18, 2026
Draft
@herin049

herin049 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Please update the README.rst in opentelemetry-proto/README.rst

@herin049 herin049 moved this to Reviewed PRs that need fixes in Python PR digest May 19, 2026
adriangb added a commit to pydantic/opentelemetry-python that referenced this pull request May 19, 2026
@adriangb @claude
docs: update opentelemetry-proto README to v1.10.0
bdb1139 
Address review feedback on open-telemetry#5223: the bundled proto definitions were
bumped from v1.9.0 to v1.10.0, so the README version references should
match.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@adriangb

adriangb commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for the quick review @herin049 !

Done — updated both v1.9.0 references in opentelemetry-proto/README.rst to v1.10.0 in bdb1139.

I left opentelemetry-proto-json/README.rst unchanged since proto_codegen.sh only regenerates the opentelemetry-proto package; the JSON package's generated code is still on v1.9.0. Happy to bump it if desired.

@herin049

herin049 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Thanks for the quick review @herin049 !

Done — updated both v1.9.0 references in opentelemetry-proto/README.rst to v1.10.0 in bdb1139.

I left opentelemetry-proto-json/README.rst unchanged since proto_codegen.sh only regenerates the opentelemetry-proto package; the JSON package's generated code is still on v1.9.0. Happy to bump it if desired.

Thanks. I've opened another PR to bump the JSON package to v1.10.0 already.

@github-project-automation github-project-automation Bot moved this from Reviewed PRs that need fixes to Approved PRs in Python PR digest May 19, 2026
@adriangb

adriangb commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

does this need an api-change label or something?

@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label May 19, 2026
emdneto
emdneto approved these changes May 19, 2026
View reviewed changes

@emdneto emdneto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. @adriangb you'll have to git ammend to remove the Claude bot e-mail from Co-authored-by: in the commit, otherwise, easycla CI won't pass.

@adriangb
Bump bundled opentelemetry-proto to v1.10.0 and regenerate
33ea2bc 
Update PROTO_REPO_BRANCH_OR_COMMIT in scripts/proto_codegen.sh from
v1.9.0 to v1.10.0, regenerate the generated *_pb2.py / *_pb2.pyi files,
and update the opentelemetry-proto README version references to match.

The motivation is the profiles v1development proto: in the v1.9.0 pin
the Sample message carried outdated field numbers
(stack_index=1, values=2, attribute_indices=3, link_index=4,
timestamps_unix_nano=5). v1.10.0 (2026-03-09) renumbers it to
stack_index=1, attribute_indices=2, link_index=3, values=4,
timestamps_unix_nano=5, which the regenerated descriptors now reflect.

The bump also pulls in unrelated proto changes between v1.9.0 and
v1.10.0: common v1 gains AnyValue.string_value_strindex and
KeyValue.key_strindex fields (development, profiling-oriented), and a
SeverityNumber doc-comment was dropped in logs v1.
@adriangb
adriangb force-pushed the bump-otlp-proto-v1.10.0 branch from 31d7886 to 33ea2bc Compare May 19, 2026 17:28
@adriangb

adriangb commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Sounds good. @adriangb you'll have to git ammend to remove the Claude bot e-mail from Co-authored-by: in the commit, otherwise, easycla CI won't pass.

Done!

aabmass
aabmass approved these changes May 20, 2026
View reviewed changes

@aabmass aabmass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aabmass
aabmass added this pull request to the merge queue May 20, 2026
@aabmass aabmass moved this from Approved PRs to Ready for merge in Python PR digest May 20, 2026
Merged via the queue into open-telemetry:main with commit b5d6fcd May 20, 2026
480 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for merge to Done in Python PR digest May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes
@emdneto emdneto emdneto approved these changes
@herin049 herin049 herin049 approved these changes

Assignees

No one assigned

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adriangb @herin049 @aabmass @emdneto