feat: update EnvironmentGetter and EnvironmentSetter to use normalized environment variable names#5119
Merged
Merged
Conversation
MikeGoldsmith
approved these changes
Apr 17, 2026
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks @herin049 🚀
tammy-baylis-swi
approved these changes
Apr 23, 2026
…d environment variable names
herin049
force-pushed
the
feat/revise-env-carrier
branch
from
April 29, 2026 21:20
715ed3a to
c4b6e89
Compare
xrmx
approved these changes
May 8, 2026
This was referenced May 18, 2026
pellared
added a commit
to pellared/opentelemetry-specification
that referenced
this pull request
May 20, 2026
Per open-telemetry/opentelemetry-python#5119 Towards open-telemetry#5040 Co-authored-by: Armin Ruech <[email protected]>
hilmarf
pushed a commit
to apeirora/opentelemetry-specification
that referenced
this pull request
Jun 1, 2026
Per open-telemetry/opentelemetry-python#5119 Towards open-telemetry#5040 Co-authored-by: Armin Ruech <[email protected]>
pellared
added a commit
to cijothomas/opentelemetry-specification
that referenced
this pull request
Jun 2, 2026
…y#5102) Towards open-telemetry#5040 ## Changes Clarifies the environment variable propagation carrier key normalization requirements: - `Set` writes values using normalized key names. - `Get` normalizes both the requested propagator key and carrier keys before matching. - `Keys` returns normalized key names. ## Motivation The existing text defined how key names are normalized, but it did not explicitly say where that normalization applies. This PR clarifies that normalization is part of the carrier behavior for writing, reading, and listing keys. This follows the robustness principle: carriers write the normalized representation, while getters can still accept a non-normalized environment variable key if it normalizes to the requested propagation key. For example, a non-normalized `traceparent` environment variable can still be used by the propagation getter when matching `TRACEPARENT`. This retrospects open-telemetry#4944 (comment) now that implementations are in place. ## Implementation references - Go: open-telemetry/opentelemetry-go-contrib#8761 - .NET: open-telemetry/opentelemetry-dotnet#7174 - Java: open-telemetry/opentelemetry-java#8233 - Python: open-telemetry/opentelemetry-python#5119 - Swift: open-telemetry/opentelemetry-swift-core#47 Related Java discussion: open-telemetry/opentelemetry-java#8233 (comment)
dashpole
pushed a commit
to dashpole/opentelemetry-specification
that referenced
this pull request
Jun 8, 2026
…y#5102) Towards open-telemetry#5040 ## Changes Clarifies the environment variable propagation carrier key normalization requirements: - `Set` writes values using normalized key names. - `Get` normalizes both the requested propagator key and carrier keys before matching. - `Keys` returns normalized key names. ## Motivation The existing text defined how key names are normalized, but it did not explicitly say where that normalization applies. This PR clarifies that normalization is part of the carrier behavior for writing, reading, and listing keys. This follows the robustness principle: carriers write the normalized representation, while getters can still accept a non-normalized environment variable key if it normalizes to the requested propagation key. For example, a non-normalized `traceparent` environment variable can still be used by the propagation getter when matching `TRACEPARENT`. This retrospects open-telemetry#4944 (comment) now that implementations are in place. ## Implementation references - Go: open-telemetry/opentelemetry-go-contrib#8761 - .NET: open-telemetry/opentelemetry-dotnet#7174 - Java: open-telemetry/opentelemetry-java#8233 - Python: open-telemetry/opentelemetry-python#5119 - Swift: open-telemetry/opentelemetry-swift-core#47 Related Java discussion: open-telemetry/opentelemetry-java#8233 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the
EnvironmentGetterandEnvironmentSetterclasses to normalize environment variable names based on the updated environment variable spec.Fixes #5097
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: