feat: add experimental logger configurator#4980
Merged
Merged
Conversation
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
herin049
force-pushed
the
feat/logger-configurator
branch
from
April 4, 2026 02:25
e1fb0ba to
e420606
Compare
herin049
marked this pull request as ready for review
April 4, 2026 03:20
herin049
added
Approve Public API check
xrmx
approved these changes
Apr 8, 2026
xrmx
left a comment
xrmx
left a comment
Contributor
There was a problem hiding this comment.
Other than the naming of a couple of attributes LGTM, thanks!
MikeGoldsmith
approved these changes
Apr 8, 2026
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
Member
There was a problem hiding this comment.
Looks good but have one suggestion for using WeakSet.
herin049
force-pushed
the
feat/logger-configurator
branch
from
April 9, 2026 01:30
1c36493 to
283a54f
Compare
xrmx
enabled auto-merge (squash)
April 9, 2026 07:29
github-project-automation
Bot
moved this from Ready for review
to Done
in Python PR digest
chimchim89
pushed a commit
to chimchim89/opentelemetry-python
that referenced
this pull request
Apr 15, 2026
* feat: add experimental LoggerConfigurator * update SDK configuration to utilize logger configurator * generalize rule based configurator * add safe logger configurator application * add unit tests * update CHANGELOG.md * update type annotation for active loggers * Address PR comments. --------- Co-authored-by: Riccardo Magliocchetti <[email protected]>
Vitexus
pushed a commit
to Vitexus/opentelemetry-python
that referenced
this pull request
Apr 30, 2026
* feat: add experimental LoggerConfigurator * update SDK configuration to utilize logger configurator * generalize rule based configurator * add safe logger configurator application * add unit tests * update CHANGELOG.md * update type annotation for active loggers * Address PR comments. --------- Co-authored-by: Riccardo Magliocchetti <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #4861 to implement part of the Logging SDK spec to support logger configuration https://opentelemetry.io/docs/specs/otel/logs/sdk/#loggerconfigurator
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: