Skip to content

opentelemetry-sdk: sketch of an OpAMP integration#4646

Merged
xrmx merged 19 commits into
open-telemetry:mainfrom
xrmx:opamp-prototype-integration
Jun 15, 2026
Merged

opentelemetry-sdk: sketch of an OpAMP integration#4646
xrmx merged 19 commits into
open-telemetry:mainfrom
xrmx:opamp-prototype-integration

Conversation

@xrmx

@xrmx xrmx commented Jun 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This is a basic integration for setting up OpAMP in the sdk configurator.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label Mar 5, 2026
@xrmx xrmx removed the Stale label Mar 5, 2026
@github-actions

github-actions Bot commented Mar 20, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label Mar 20, 2026
@xrmx xrmx removed the Stale label Mar 20, 2026
@xrmx xrmx mentioned this pull request Mar 20, 2026
Merged
11 tasks
@xrmx
xrmx force-pushed the opamp-prototype-integration branch from f2f49fd to 579da8c Compare March 20, 2026 11:20
xrmx
xrmx commented Mar 20, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
@xrmx
xrmx marked this pull request as ready for review March 20, 2026 11:41
@xrmx
xrmx requested a review from a team as a code owner March 20, 2026 11:41
@xrmx xrmx moved this to Reviewed PRs that need fixes in Python PR digest Mar 20, 2026
pmcollins
pmcollins reviewed Mar 20, 2026
View reviewed changes

@pmcollins pmcollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Added a comment.

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
kelseyma
kelseyma reviewed Mar 20, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
MikeGoldsmith
MikeGoldsmith reviewed Apr 2, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
@xrmx
xrmx force-pushed the opamp-prototype-integration branch from 23f3ff7 to 830fd1b Compare April 9, 2026 09:19
@xrmx
xrmx requested review from kelseyma and pmcollins April 14, 2026 13:54
pmcollins
pmcollins reviewed Apr 20, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
@xrmx
xrmx force-pushed the opamp-prototype-integration branch from 1691294 to 4774c5b Compare May 8, 2026 15:52
@xrmx
xrmx requested review from MikeGoldsmith and pmcollins May 10, 2026 10:14
@xrmx

xrmx commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

Added both a pre and post init hook. Failures in the tests looks unrelated but need to take a closer look at them since they are reproducible on CI only on this branch.

pmcollins
pmcollins reviewed May 11, 2026
View reviewed changes
Comment thread opentelemetry-sdk/tests/test_configurator.py
pmcollins
pmcollins reviewed May 11, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
@emdneto

emdneto commented May 12, 2026

Copy link
Copy Markdown
Member

Thanks for the PR!

Just a heads-up: we no longer update CHANGELOG.md directly. The changelog is now generated from changelog fragments using Towncrier.

Please add the appropriate changelog fragment for this change instead of editing CHANGELOG.md manually. You can find the instructions and expected format in CONTRIBUTING.md.

@xrmx
xrmx force-pushed the opamp-prototype-integration branch from f85dc04 to 12143fd Compare May 13, 2026 15:42
xrmx
xrmx commented May 14, 2026
View reviewed changes
Comment thread .changelog/4646.changed Outdated
pmcollins
pmcollins approved these changes May 18, 2026
View reviewed changes

@pmcollins pmcollins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- looking forward to using this.

@github-project-automation github-project-automation Bot moved this from Reviewed PRs that need fixes to Approved PRs in Python PR digest May 18, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label Jun 2, 2026
aabmass
aabmass approved these changes Jun 9, 2026
View reviewed changes
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py Outdated
@aabmass aabmass moved this from Approved PRs to Approved PRs that need fixes in Python PR digest Jun 9, 2026
@github-actions github-actions Bot removed the Stale label Jun 10, 2026
@xrmx
xrmx added this pull request to the merge queue Jun 15, 2026
Merged via the queue into open-telemetry:main with commit bc3cdda Jun 15, 2026
479 checks passed
@xrmx
xrmx deleted the opamp-prototype-integration branch June 15, 2026 15:34
@github-project-automation github-project-automation Bot moved this from Approved PRs that need fixes to Done in Python PR digest Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmcollins pmcollins pmcollins approved these changes
@aabmass aabmass aabmass approved these changes
@kelseyma kelseyma Awaiting requested review from kelseyma
@MikeGoldsmith MikeGoldsmith Awaiting requested review from MikeGoldsmith

Assignees

No one assigned

Labels

None yet

Projects

Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xrmx @emdneto @pmcollins @aabmass @MikeGoldsmith @kelseyma