Separate lint into several jobs#3902
Merged
Merged
Conversation
ocelotl
marked this pull request as draft
May 6, 2024 17:49
ocelotl
force-pushed
the
issue_3887
branch
2 times, most recently
from
May 6, 2024 20:43
07eb44a to
a9e2fb7
Compare
ocelotl
force-pushed
the
issue_3887
branch
3 times, most recently
from
May 6, 2024 21:50
161873e to
bb8118a
Compare
ocelotl
marked this pull request as ready for review
May 6, 2024 21:50
ocelotl
marked this pull request as draft
May 6, 2024 21:51
ocelotl
marked this pull request as ready for review
June 11, 2024 20:50
lzchen
reviewed
Jun 12, 2024
lzchen
reviewed
Jun 12, 2024
lzchen
reviewed
Jun 12, 2024
lzchen
reviewed
Jun 12, 2024
lzchen
reviewed
Jun 12, 2024
Contributor
|
Do we really want to do this without the parallelization benefits that we got in -contrib? |
xrmx
reviewed
Jun 18, 2024
emdneto
reviewed
Jul 2, 2024
Contributor
Author
We will get the same parallelization benefits here since we will be creating more, smaller lint jobs instead of having just a big one. |
Contributor
|
Apologies for the delay in this pr. I want to bring it up one more time during the SIG to get the final opinions about it before approving. |
This reverts commit 34d6139.
lzchen
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3887