Refactor SDK MeterProvider#2401
Merged
ocelotl merged 4 commits intoopen-telemetry:mainfrom Jan 26, 2022
Merged
Conversation
srikanthccv
added
Skip Changelog
ocelotl
reviewed
Jan 24, 2022
ocelotl
approved these changes
Jan 24, 2022
aabmass
approved these changes
Jan 24, 2022
codeboten
approved these changes
Jan 24, 2022
lzchen
reviewed
Jan 26, 2022
lzchen
approved these changes
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes race in
shutdownand correctly sets the measurement consumer callback for theMetricReaderFixes #2331
Fixes #2245
Fixes #2239
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e opentelemetry-sdkChecklist: