Skip to content

Add measurement consumer#2339

Merged
ocelotl merged 14 commits intoopen-telemetry:mainfrom
ocelotl:issue_2326
Jan 13, 2022
Merged

Add measurement consumer#2339
ocelotl merged 14 commits intoopen-telemetry:mainfrom
ocelotl:issue_2326

Conversation

@ocelotl
Copy link
Copy Markdown
Contributor

@ocelotl ocelotl commented Dec 17, 2021

Fixes #2326

@ocelotl ocelotl self-assigned this Dec 17, 2021
@ocelotl ocelotl requested review from a team, aabmass, lzchen and srikanthccv December 17, 2021 21:32
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/instrument.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py Outdated
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2022
@lzchen lzchen removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2022
@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Jan 12, 2022

@ocelotl
Why are we skipping changelog for this pr?

@ocelotl
Copy link
Copy Markdown
Contributor Author

ocelotl commented Jan 12, 2022

I am skipping changelogs for all metrics components because they are still private

Copy link
Copy Markdown
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking bug

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/instrument.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py Outdated
Comment thread opentelemetry-sdk/tests/metrics/test_measurement_consumer.py Outdated
Comment thread opentelemetry-sdk/tests/metrics/test_measurement_consumer.py Outdated
Comment thread opentelemetry-sdk/tests/metrics/test_measurement_consumer.py Outdated
@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2022
@ocelotl ocelotl requested a review from aabmass January 12, 2022 23:59
@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jan 13, 2022
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/instrument.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py Outdated
@ocelotl ocelotl merged commit 6a88987 into open-telemetry:main Jan 13, 2022
@ocelotl ocelotl deleted the issue_2326 branch January 13, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary metrics Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MeasurementConsumer to metrics SDK

4 participants