So I've given this area some thought, and I think that this object would be more intuitive if we unify the formatters for distributedcontext and spancontext.

I've outlined an OTEP outlining some other advantages: open-telemetry/oteps#37, but specific to this issue:

I was taking @a-feld's suggestion and creating an object that will consume a context and be responsible for extract and injecting, something like:

class Propagator:

    def inject():
        self.formatter.inject(...)

    def extract() -> 
          self.formatter.extract(...)

To do this, I need the following information:

the context to use
the httptextformat to use for distributed context
the binaryformat to use for distributed context
the httptextformat to use for spancontext
the binaryformat to use for spancontext
the filter of values for distributedcontext (used when injecting)

That would require the constructor to take 6 fields. If I just had a single formatter for both distributedcontext and spancontext, I would only need 4.

thoughts?

Add propagators API #51

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions