Duplicate instrument handling in API #2142

Activity

1. aabmass

   added

   metrics

   on Sep 23, 2021
2. aabmass

   added

   apiAffects the API package.Affects the API package.

   on Dec 14, 2021
3. ocelotl commented on Dec 15, 2021

   

   ocelotl

   on Dec 15, 2021

   Contributor

   More actions

   • Should it be handled at the global level?
   • Which instrument fields are considered non-identifying (description?)

   I am a bit confused:

   1. What should be handled at the global level?
   2. @aabmass, is your intention to suggest description is a non-identifying instrument field?
4. lzchen

   added

   1.10.0rc1release candidate 1 for metrics GArelease candidate 1 for metrics GA

   on Jan 11, 2022
5. lzchen commented on Jan 19, 2022

   

   lzchen

   on Jan 19, 2022

   Contributor

   More actions

   From specs:

   Meter implementations MUST return an error when multiple Instruments are registered under the same Meter instance using the same name.

   So should probably be done as part of error handling.
6. ocelotl commented on Jan 25, 2022

   

   ocelotl

   on Jan 25, 2022

   Contributor

   More actions

   From specs:

   Meter implementations MUST return an error when multiple Instruments are registered under the same Meter instance using the same name.

   So should probably be done as part of error handling.

   Should this issue be closed @lzchen in favor of implementing this later with general error handling?
7. lzchen commented on Jan 25, 2022

   

   lzchen

   on Jan 25, 2022

   Contributor

   More actions

   @ocelotl
   I think the behavior won't completely be fixed with error handling. We still need to implement the "checking of valid instrument creation" part.
8. ocelotl

   self-assigned this

   on Jan 25, 2022
9. ocelotl

   added 2 commits that reference this issue on Jan 26, 2022

   Add check for duplicate instrument names

   ...

   This issue will close once commit 1cf32f0 is merged into the 'main' branch.

   1cf32f0

   Add check for duplicate instrument names

   ...

   This issue will close once commit 268694b is merged into the 'main' branch.

   268694b
10. ocelotl

    added a commit that references this issue on Feb 23, 2022

    Add check for duplicate instrument names

    ...

    This issue will close once commit b68d744 is merged into the 'main' branch.

    b68d744
11. ocelotl

    added 2 commits that reference this issue on Mar 3, 2022

    Add check for duplicate instrument names

    ...

    This issue will close once commit b93e82b is merged into the 'main' branch.

    b93e82b

    Add check for duplicate instrument names

    ...

    This issue will close once commit ba526d1 is merged into the 'main' branch.

    ba526d1
12. ocelotl

    added a commit that references this issue on Mar 25, 2022

    Add check for duplicate instrument names

    ...

    This issue will close once commit c5649c2 is merged into the 'main' branch.

    c5649c2
13. ocelotl

    added a commit that references this issue on Apr 12, 2022

    Add check for duplicate instrument names

    ...

    This issue will close once commit b5d824c is merged into the 'main' branch.

    b5d824c
14. ocelotl

    closed this as completedin #2409on Apr 12, 2022
15. ocelotl

    added a commit that references this issue on Apr 12, 2022

    Add check for duplicate instrument names (#2409)

    ...

    This issue will close once commit cb60b54 is merged into the 'main' branch.

    cb60b54