Profiles: Remove has_* debug info fields, they are moving to attributes.#595
Merged
tigrannajaryan merged 2 commits intoopen-telemetry:mainfrom Aug 7, 2025
Merged
Profiles: Remove has_* debug info fields, they are moving to attributes.#595tigrannajaryan merged 2 commits intoopen-telemetry:mainfrom
tigrannajaryan merged 2 commits intoopen-telemetry:mainfrom
Conversation
Member
Author
|
@jhalliday @felixge @florianl FYI - sending this for feedback. |
christos68k
reviewed
Oct 31, 2024
arminru
changed the title
florianl
reviewed
Jul 15, 2025
3 tasks
aalexand
changed the title
florianl
approved these changes
Jul 21, 2025
christos68k
approved these changes
Jul 21, 2025
felixge
approved these changes
Jul 24, 2025
florianl
added a commit
to florianl/opentelemetry-proto
that referenced
this pull request
Jul 30, 2025
Similar to the boolean attributes `Mapping.has_*` (open-telemetry#595 and open-telemetry/semantic-conventions#2522) also drop `Location.is_folded`. The complementary PR for the OTel SemConv, that builds on top of open-telemetry/semantic-conventions#2522 is florianl/semantic-conventions#1
Member
Author
|
@tigrannajaryan This is ready to be merged. |
tigrannajaryan
added a commit
that referenced
this pull request
Aug 11, 2025
Similar to the boolean attributes `Mapping.has_*` (#595 and open-telemetry/semantic-conventions#2522) also drop `Location.is_folded`. The complementary PR for the OTel SemConv, that builds on top of open-telemetry/semantic-conventions#2522 is florianl/semantic-conventions#1 Co-authored-by: Tigran Najaryan <[email protected]>
Merged
tigrannajaryan
pushed a commit
that referenced
this pull request
Sep 2, 2025
### Changed - profiles: drop gzip requirement. [#661](#661) - profiles: avoid `optional` keyword usage. [#659](#659) - profiles: make `profile_id` optional. [#665](#665) - profiles: use single `Profile.sample_type` and clarify use of timestamps. [#649](#649) - all: add notes about the attribute values restrictions. [#683](https://github.com/open-telemetry/opentelemetry-proto/pull/683)<br>⚠️ **IMPORTANT**: These restrictions can be dropped in a future minor release. - profiles: clarify usage of the zero value as the first element of tables in `ProfilesDictionary`. [#688](#688), [#698](#698) - profiles: unsigned `time_nanos` and `duration_nanos` in `Profile`. [#692](#692) - profiles: improve attribute encoding in `ProfilesDictionary`. [#672](#672) - profiles: simplify profile stack trace representation. [#708](#708) ### Fixed - examples: fix OTLP JSON Event example body. [#666](#666) - docs: minor specification fixes around `UNAVAILABLE` and `RetryInfo`. [#669](#669) ### Removed - profiles: remove `default_sample_type`. [#679](#679) - profiles: remove `has_*` debug info fields, they are moving to attributes. [#595](#595) - profiles: remove `Location.is_folded`. [#690](#690)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The has_* debug info fields were derived from the pprof format. We decided to move them to attributes, see open-telemetry/semantic-conventions#2522.