Skip to content

initial PIE (php extension installer) support#163

Merged
brettmc merged 3 commits into
open-telemetry:mainfrom
brettmc:pie
Feb 6, 2025
Merged

initial PIE (php extension installer) support#163
brettmc merged 3 commits into
open-telemetry:mainfrom
brettmc:pie

Conversation

@brettmc

@brettmc brettmc commented Jan 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

this should work for linux, but it looks like some rework is required for windows

Closes: open-telemetry/opentelemetry-php#1494

@brettmc
initial PIE (php extension installer) support
46042e0 
this should work for linux, but it looks like some rework is required for windows
@brettmc
brettmc requested a review from a team as a code owner January 30, 2025 01:54
@brettmc

brettmc commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

tested this locally, using my fork:

pie repository:add vcs https://github.com/brettmc/opentelemetry-php-instrumentation
pie install open-telemetry/ext-opentelemetry:dev-pie

output:

You are running PHP 8.4.3
Target PHP installation: 8.4.3 nts, on Linux/OSX/etc x86_64 (from /usr/local/bin/php)
Found package: open-telemetry/ext-opentelemetry:dev-pie which provides ext-opentelemetry
Extracted open-telemetry/ext-opentelemetry:dev-pie source to: /root/.pie/php8.4_32813b481b050e157b40a63f3e9abc8f/vendor/open-telemetry/ext-opentelemetry/ext
phpize complete.
Configure complete.
Build complete: /root/.pie/php8.4_32813b481b050e157b40a63f3e9abc8f/vendor/open-telemetry/ext-opentelemetry/ext/modules/opentelemetry.so
Install complete: /usr/local/lib/php/extensions/no-debug-non-zts-20240924/opentelemetry.so
✅ Extension is enabled and loaded in /usr/local/bin/php

bobstrecansky
bobstrecansky approved these changes Jan 30, 2025
View reviewed changes

@bobstrecansky bobstrecansky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are you planning on working on the windows piece, or shall we wait for someone to request it?

@brettmc

brettmc commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

Are you planning on working on the windows piece, or shall we wait for someone to request it?

Updated to, I think, work for windows. PIE wants a specific naming convention for the windows artifacts, which I' think I've wrangled.

@brettmc
brettmc requested a review from bobstrecansky January 31, 2025 05:41
@brettmc
brettmc merged commit 47fc21c into open-telemetry:main Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobstrecansky bobstrecansky Awaiting requested review from bobstrecansky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[opentelemetry-php-instrumentation] Support PIE Installer

2 participants

@brettmc @bobstrecansky