Skip to content

Fixed wrong db.system.name when using pdo_pgsql#508

Merged
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
yoshz:bugfix/doctrine-dbsystem-name
Feb 11, 2026
Merged

Fixed wrong db.system.name when using pdo_pgsql#508
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
yoshz:bugfix/doctrine-dbsystem-name

Conversation

@yoshz

@yoshz yoshz commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

When you use pdo_pgsql as Doctrine driver you get db.system.name=unknown instead of db.system.name=postgresql because "pdo_" is used to trim the prefix which ends up in "gsql".

@yoshz
yoshz requested a review from a team as a code owner February 9, 2026 20:50

@ChrisLightfootWild ChrisLightfootWild left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Comment thread src/Instrumentation/Doctrine/src/AttributesResolver.php Outdated
Comment thread src/Instrumentation/Doctrine/src/AttributesResolver.php Outdated
@codecov

codecov Bot commented Feb 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.54%. Comparing base (60eaede) to head (491fbd4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nstrumentation/Doctrine/src/AttributesResolver.php 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #508   +/-   ##
=========================================
  Coverage     82.54%   82.54%           
  Complexity     2338     2338           
=========================================
  Files           159      159           
  Lines          8823     8823           
=========================================
  Hits           7283     7283           
  Misses         1540     1540           
Flag Coverage Δ
Aws 93.37% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Exporter/Instana 49.80% <ø> (ø)
Instrumentation/AwsSdk 82.00% <ø> (ø)
Instrumentation/CakePHP 20.42% <ø> (ø)
Instrumentation/CodeIgniter 79.31% <ø> (ø)
Instrumentation/Curl 86.88% <ø> (ø)
Instrumentation/Doctrine 92.82% <50.00%> (ø)
Instrumentation/ExtAmqp 88.80% <ø> (ø)
Instrumentation/ExtRdKafka 86.13% <ø> (ø)
Instrumentation/Guzzle 76.25% <ø> (ø)
Instrumentation/HttpAsyncClient 78.94% <ø> (ø)
Instrumentation/HttpConfig 28.76% <ø> (ø)
Instrumentation/IO 0.00% <ø> (ø)
Instrumentation/Laravel 71.65% <ø> (ø)
Instrumentation/MongoDB 76.84% <ø> (ø)
Instrumentation/MySqli 93.39% <ø> (ø)
Instrumentation/OpenAIPHP 86.71% <ø> (ø)
Instrumentation/PDO 85.67% <ø> (ø)
Instrumentation/PostgreSql 91.36% <ø> (ø)
Instrumentation/Psr14 77.41% <ø> (ø)
Instrumentation/Psr15 89.74% <ø> (ø)
Instrumentation/Psr16 97.43% <ø> (ø)
Instrumentation/Psr18 79.41% <ø> (ø)
Instrumentation/Psr3 67.70% <ø> (ø)
Instrumentation/Psr6 97.56% <ø> (ø)
Instrumentation/ReactPHP 99.41% <ø> (ø)
Instrumentation/Session 94.28% <ø> (ø)
Instrumentation/Slim 84.21% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/CloudTrace 90.69% <ø> (ø)
Propagation/Instana 98.07% <ø> (ø)
Propagation/ServerTiming 94.73% <ø> (ø)
Propagation/TraceResponse 94.73% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
ResourceDetectors/DigitalOcean 100.00% <ø> (ø)
Sampler/Xray 78.38% <ø> (ø)
Shims/OpenTracing 92.99% <ø> (ø)
SqlCommenter 95.58% <ø> (ø)
Symfony 88.14% <ø> (ø)
Utils/Test 87.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nstrumentation/Doctrine/src/AttributesResolver.php 80.39% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60eaede...491fbd4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Chris Lightfoot-Wild <[email protected]>
@linux-foundation-easycla

linux-foundation-easycla Bot commented Feb 10, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@bobstrecansky
bobstrecansky merged commit 4239954 into open-telemetry:main Feb 11, 2026
163 of 175 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants