Remove curl hooks from IO contrib package#441
Merged
brettmc merged 10 commits intoSep 16, 2025
Merged
Conversation
HeenaBansal20
force-pushed
the
remove-curl-instrumentation-from-io-package
branch
from
September 16, 2025 20:41
6466a69 to
4b9c450
Compare
HeenaBansal20
changed the title
HeenaBansal20
force-pushed
the
remove-curl-instrumentation-from-io-package
branch
from
September 16, 2025 20:49
4b9c450 to
b10c398
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
============================================
+ Coverage 81.90% 81.95% +0.05%
+ Complexity 1988 1986 -2
============================================
Files 137 137
Lines 8096 8091 -5
============================================
Hits 6631 6631
+ Misses 1465 1460 -5 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
brettmc
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl_init and cork_exec belongs to curl instrumentation and doesn't categorize under IO functions .
Hence removing from IO auto instrumentation package. These curl functions can be auto instrumented using auto curl package.
see discussion here
#437 (comment)