fix doctrine statement execution error#399
Merged
brettmc merged 1 commit intoJul 5, 2025
Merged
Conversation
the post callback function signature was incorrect for the case where an exception occurs, ResultInterface should be nullable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
============================================
+ Coverage 82.48% 82.50% +0.02%
Complexity 2009 2009
============================================
Files 144 144
Lines 8329 8329
============================================
+ Hits 6870 6872 +2
+ Misses 1459 1457 -2 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ChrisLightfootWild
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the post callback function signature was incorrect for the case where an exception occurs, ResultInterface should be nullable
Reference: open-telemetry/opentelemetry-php#1578 (comment)