[ReactPHP] Add required HTTP Client Metric#380
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
============================================
+ Coverage 82.14% 82.23% +0.09%
- Complexity 1801 1802 +1
============================================
Files 137 137
Lines 7594 7634 +40
============================================
+ Hits 6238 6278 +40
Misses 1356 1356 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
smaddock
changed the title
smaddock
marked this pull request as draft
June 1, 2025 01:21
smaddock
changed the title
Nevay
reviewed
Jun 1, 2025
Co-authored-by: Tobias Bachert <[email protected]>
bobstrecansky
marked this pull request as ready for review
June 4, 2025 12:08
bobstrecansky
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the SemConv required
http.client.request.durationmetric to the ReactPHP auto-instrumentation library.