Skip to content

feat: track Eloquent ORM#339

Merged
brettmc merged 4 commits into
open-telemetry:mainfrom
cedricziel:eloquent-tracing
Apr 7, 2025
Merged

feat: track Eloquent ORM#339
brettmc merged 4 commits into
open-telemetry:mainfrom
cedricziel:eloquent-tracing

Conversation

@cedricziel

Copy link
Copy Markdown
Contributor

This tracks the model interactions and allows a user to understand how the app interacts with the model classes.

It should be considered to to remove the event-based recording of SQL statements and fold them into this, or remove the sql bits completely and rely on the PDO instrumentation.

@cedricziel
cedricziel requested a review from a team as a code owner March 29, 2025 11:54
@codecov

codecov Bot commented Mar 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 68.44920% with 59 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (56e4005) to head (a793e31).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...l/src/Hooks/Illuminate/Database/Eloquent/Model.php 68.81% 58 Missing ⚠️
...rumentation/Laravel/src/LaravelInstrumentation.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #339      +/-   ##
============================================
- Coverage     80.83%   80.48%   -0.35%     
- Complexity     1502     1510       +8     
============================================
  Files           128      129       +1     
  Lines          6183     6370     +187     
============================================
+ Hits           4998     5127     +129     
- Misses         1185     1243      +58     
Flag Coverage Δ
Aws 92.24% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CakePHP 20.27% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 90.42% <ø> (ø)
Instrumentation/ExtAmqp 89.26% <ø> (ø)
Instrumentation/ExtRdKafka 86.23% <ø> (ø)
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 78.31% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 64.07% <68.44%> (+1.38%) ⬆️
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO 90.15% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 89.41% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 77.77% <ø> (ø)
Instrumentation/Psr3 59.49% <ø> (ø)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.30% <ø> (ø)
Instrumentation/Symfony 84.93% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rumentation/Laravel/src/LaravelInstrumentation.php 0.00% <0.00%> (ø)
...l/src/Hooks/Illuminate/Database/Eloquent/Model.php 68.81% <68.81%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e4005...a793e31. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/Instrumentation/Laravel/tests/Integration/LaravelInstrumentationTest.php Outdated
@cedricziel

Copy link
Copy Markdown
Contributor Author

I moved the eval to a fixture class. Should be good now.

Comment thread src/Instrumentation/Symfony/src/Propagation/EnvelopeContextPropagator.php Outdated

@ChrisLightfootWild ChrisLightfootWild left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@brettmc
brettmc merged commit 3b32d09 into open-telemetry:main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants