Skip to content

Fix post hook exception possibility in opentelemetry-auto-curl#335

Merged
brettmc merged 1 commit into
open-telemetry:mainfrom
vsimon:issue-1531
Mar 21, 2025
Merged

Fix post hook exception possibility in opentelemetry-auto-curl#335
brettmc merged 1 commit into
open-telemetry:mainfrom
vsimon:issue-1531

Conversation

@vsimon

@vsimon vsimon commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

@vsimon
Fix post hook exception possibility in opentelemetry-auto-curl
6de8833 
For open-telemetry/opentelemetry-php #1531
@vsimon
vsimon requested a review from a team as a code owner March 20, 2025 23:03
@welcome

welcome Bot commented Mar 20, 2025

Copy link
Copy Markdown

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@vsimon vsimon mentioned this pull request Mar 20, 2025
Closed
@codecov

codecov Bot commented Mar 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (dcc9821) to head (6de8833).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/Instrumentation/Curl/src/CurlHandleMetadata.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #335   +/-   ##
=========================================
  Coverage     80.42%   80.42%           
  Complexity     1500     1500           
=========================================
  Files           128      128           
  Lines          6176     6176           
=========================================
  Hits           4967     4967           
  Misses         1209     1209
Flag Coverage Δ
Aws 85.55% <ø> (ø)
Context/Swoole 0.00% <ø> (ø)
Instrumentation/CakePHP 20.27% <ø> (ø)
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 90.42% <0.00%> (ø)
Instrumentation/ExtAmqp 89.26% <ø> (ø)
Instrumentation/ExtRdKafka 86.23% <ø> (ø)
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient 78.31% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 62.68% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO 90.15% <ø> (ø)
Instrumentation/Psr14 77.14% <ø> (ø)
Instrumentation/Psr15 89.41% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 77.77% <ø> (ø)
Instrumentation/Psr3 59.49% <ø> (ø)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.30% <ø> (ø)
Instrumentation/Symfony 84.93% <ø> (ø)
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/Instrumentation/Curl/src/CurlHandleMetadata.php 78.31% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc9821...6de8833. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc
brettmc merged commit c6dadab into open-telemetry:main Mar 21, 2025
@brettmc

brettmc commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

release 0.0.4

@andreicodrutonofrei-sketch andreicodrutonofrei-sketch mentioned this pull request Jun 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[opentelemetry-php-contrib] post hook exception in opentelemetry-auto-curl

3 participants

@vsimon @brettmc @ChrisLightfootWild