[Laravel] Allow Laravel 12#333
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=========================================
Coverage 80.42% 80.42%
Complexity 1502 1502
=========================================
Files 128 128
Lines 6176 6176
=========================================
Hits 4967 4967
Misses 1209 1209 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I propose we wait until #315 lands to ensure that the tests all pass under PHP 8.4. |
|
Hey @IonBazan 👋 Please could you merge main so the 8.4 pipeline could run for this? |
ChrisLightfootWild
left a comment
ChrisLightfootWild
left a comment
There was a problem hiding this comment.
Thanks @IonBazan 👍
I've not had time to actually test Laravel 12 myself yet but, given the tests all pass, I would be happy to add my ✅
Have you managed to run this in a L12 test app?
|
Hey sorry, unfortunately I don't have any L12 app ready yet. I believe there weren't any major changes that would break current instrumentation though. |
|
Hi @ChrisLightfootWild, can we please get this merged? I believe there are multiple mirror PRs created in subtrees as well. |
|
released 1.1.1 with this change |
3 participants
Allows Laravel 12 to be installed with
open-telemetry/opentelemetry-auto-laravel