Skip to content

Update contrib packages to SemConv 1.30#327

Merged
brettmc merged 35 commits into
open-telemetry:mainfrom
brettmc:semconv-130
Feb 11, 2025
Merged

Update contrib packages to SemConv 1.30#327
brettmc merged 35 commits into
open-telemetry:mainfrom
brettmc:semconv-130

Conversation

@brettmc

@brettmc brettmc commented Feb 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • update all contrib packages using SemConv to 1.30.0
  • update deprecated semconv attributes to their suggested replacements
  • dropped 7.4 support for most packages

brettmc added 26 commits February 6, 2025 12:24
@codecov

codecov Bot commented Feb 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 62.82723% with 71 lines in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (ee99079) to head (402dc53).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...AsyncClient/src/HttpAsyncClientInstrumentation.php 37.50% 5 Missing ⚠️
...strumentation/MySqli/src/MySqliInstrumentation.php 75.00% 5 Missing ⚠️
...Instrumentation/Psr15/src/Psr15Instrumentation.php 54.54% 5 Missing ⚠️
...Instrumentation/Psr18/src/Psr18Instrumentation.php 28.57% 5 Missing ⚠️
...entation/Symfony/src/HttpClientInstrumentation.php 37.50% 5 Missing ⚠️
...mentation/Symfony/src/MessengerInstrumentation.php 54.54% 5 Missing ⚠️
...rumentation/Symfony/src/SymfonyInstrumentation.php 44.44% 5 Missing ⚠️
.../src/Watchers/RedisCommand/RedisCommandWatcher.php 0.00% 4 Missing ⚠️
...strumentation/Guzzle/src/GuzzleInstrumentation.php 40.00% 3 Missing ⚠️
...nstrumentation/CakePHP/src/Hooks/CakeHookTrait.php 0.00% 2 Missing ⚠️
... and 20 more

❗ There is a different number of reports uploaded between BASE (ee99079) and HEAD (402dc53). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ee99079) HEAD (402dc53)
Instrumentation/PDO 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #327      +/-   ##
============================================
- Coverage     85.87%   80.67%   -5.20%     
- Complexity     1081     1295     +214     
============================================
  Files            73      114      +41     
  Lines          4480     5486    +1006     
============================================
+ Hits           3847     4426     +579     
- Misses          633     1060     +427
Flag Coverage Δ
Instrumentation/CakePHP 20.27% <25.00%> (+0.27%) ⬆️
Instrumentation/CodeIgniter 73.77% <75.00%> (ø)
Instrumentation/Curl 90.66% <80.00%> (ø)
Instrumentation/ExtAmqp 89.26% <100.00%> (?)
Instrumentation/ExtRdKafka 87.73% <87.50%> (?)
Instrumentation/Guzzle 69.51% <40.00%> (ø)
Instrumentation/HttpAsyncClient 78.31% <37.50%> (-2.94%) ⬇️
Instrumentation/IO 70.68% <50.00%> (ø)
Instrumentation/Laravel 62.17% <63.33%> (?)
Instrumentation/MongoDB 74.03% <60.00%> (+1.39%) ⬆️
Instrumentation/MySqli 96.09% <76.19%> (-0.02%) ⬇️
Instrumentation/OpenAIPHP 87.31% <100.00%> (ø)
Instrumentation/PDO ?
Instrumentation/Psr14 77.14% <50.00%> (ø)
Instrumentation/Psr15 89.41% <54.54%> (-4.42%) ⬇️
Instrumentation/Psr16 97.56% <100.00%> (ø)
Instrumentation/Psr18 77.77% <28.57%> (-3.39%) ⬇️
Instrumentation/Psr3 59.49% <0.00%> (?)
Instrumentation/Psr6 97.67% <100.00%> (ø)
Instrumentation/Slim 86.89% <71.42%> (ø)
Instrumentation/Symfony 84.93% <46.42%> (-3.78%) ⬇️
Instrumentation/Yii 77.68% <75.00%> (ø)
Logs/Monolog 100.00% <100.00%> (?)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse 100.00% <ø> (ø)
ResourceDetectors/Azure 91.66% <100.00%> (?)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (?)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rumentation/ExtAmqp/src/ExtAmqpInstrumentation.php 89.26% <100.00%> (ø)
...n/Laravel/src/Hooks/Illuminate/Console/Command.php 90.00% <100.00%> (ø)
...vel/src/Hooks/Illuminate/Contracts/Http/Kernel.php 83.56% <100.00%> (ø)
...n/Laravel/src/Hooks/Illuminate/Queue/SyncQueue.php 92.59% <100.00%> (ø)
...nstrumentation/Laravel/src/Watchers/LogWatcher.php 94.73% <ø> (ø)
...trumentation/Laravel/src/Watchers/QueryWatcher.php 95.83% <100.00%> (ø)
...n/Laravel/src/Watchers/RedisCommand/Serializer.php 92.30% <100.00%> (ø)
src/Instrumentation/MySqli/src/MySqliTracker.php 93.00% <100.00%> (-0.07%) ⬇️
...ntation/OpenAIPHP/src/OpenAIPHPInstrumentation.php 87.31% <100.00%> (ø)
...Instrumentation/Psr16/src/Psr16Instrumentation.php 97.56% <100.00%> (ø)
... and 35 more

... and 27 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee99079...402dc53. Read the comment docs.

@brettmc
drop 7.4 testing
09ed016
@brettmc
fixing build errors
73b1952 
- bump psr3 + monolog deps to php8.1
- fix azure detector semconv, add composer dependency
@brettmc
fixing more broken things
01ce182
@brettmc
brettmc marked this pull request as ready for review February 6, 2025 09:57
@brettmc
brettmc requested a review from a team as a code owner February 6, 2025 09:57
@flc1125 flc1125 mentioned this pull request Feb 7, 2025
Open
@brettmc brettmc mentioned this pull request Feb 8, 2025
Merged
ChrisLightfootWild
ChrisLightfootWild reviewed Feb 9, 2025
View reviewed changes
Comment thread src/Instrumentation/Laravel/src/Hooks/Illuminate/Contracts/Queue/Queue.php Outdated
@brettmc
fix message span names
3d4232a 
in semconv 1.27 the order of operation+queue switched
@ChrisLightfootWild ChrisLightfootWild mentioned this pull request Feb 11, 2025
Closed
ChrisLightfootWild
ChrisLightfootWild reviewed Feb 11, 2025
View reviewed changes
Comment thread src/Instrumentation/Laravel/src/Hooks/Illuminate/Contracts/Queue/Queue.php
Comment thread src/Instrumentation/Laravel/src/Hooks/Illuminate/Queue/Worker.php
@brettmc
brettmc merged commit 2d17302 into open-telemetry:main Feb 11, 2025
@jderusse

jderusse commented Mar 12, 2025

Copy link
Copy Markdown

Do you plan to release the amqp subtree split?

Its latest release (version 0.04) is not compatible with SemConv 1.30 (this is fixed by this PR). But nothing forbids composer to install contrib-auto-ext-amqp 0.0.4 and SemvConv 1.30

@brettmc

brettmc commented Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

@jderusse thanks for the reminder. I've tagged new versions of packages that had semconv updates that were not yet released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild left review comments
@bobstrecansky bobstrecansky bobstrecansky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettmc @jderusse @bobstrecansky @ChrisLightfootWild