Add db statements to linked spans#325
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
|
Thank you @GrzegorzDrozd! Once you've signed the CLA we'll be able to review and merge. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
============================================
- Coverage 85.87% 85.62% -0.25%
+ Complexity 1081 1049 -32
============================================
Files 73 71 -2
Lines 4480 4231 -249
============================================
- Hits 3847 3623 -224
+ Misses 633 608 -25
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
You mean this: |
|
@brettmc Thank you for approving this PR. What's next? Failing checks are nowhere near code I changed. Am I suppose to fix them? If not then when can we expect merge and release? |
No, not your problem. I was going to give it a day or two to see if anybody else wants to review or provide feedback before I merge. |
|
@brettmc Thanks for merging :) any ETA on possible release date ? |
|
Done, was just waiting on another PR to be merged. |
3 participants
This PR introduces a new feature to the PDO auto instrumentation that enhances the observability of database queries, specifically for clients that do not support linked spans (e.g., New Relic).
Changes:
OTEL_PHP_INSTRUMENTATION_PDO_DISTRIBUTE_STATEMENT_TO_LINKED_SPANS) and cfg variable (otel.instrumentation.pdo.distribute_statement_to_linked_spans).PDO::preparebut also inPDOStatement::executeandPDOStatement::fetchAll). It will result in more data being sent, be aware that it might generate additional cost. It is disabled by default.