Added schema URL for all packages lower than 1.0.0 #273

weslenteche · 2024-06-18T23:17:31Z

Added schema URL inclusion for all packages listed below that are in a version lower than 1.0.0.

open-telemetry/opentelemetry-auto-cakephp v0.0.1
open-telemetry/opentelemetry-auto-codeigniter v0.0.7
open-telemetry/opentelemetry-auto-ext-amqp v0.0.3
open-telemetry/opentelemetry-auto-guzzle v0.0.2
open-telemetry/opentelemetry-auto-io v.0.0.11
open-telemetry/opentelemetry-auto-laravel v.0.0.25
open-telemetry/opentelemetry-auto-mongodb v.0.0.5
open-telemetry/opentelemetry-auto-openai-php v.0.0.1
open-telemetry/opentelemetry-auto-pdo v0.0.13
open-telemetry/opentelemetry-auto-psr3 v.0.0.6
open-telemetry/opentelemetry-auto-psr6 v.0.0.2
open-telemetry/opentelemetry-auto-psr14 v.0.0.2
open-telemetry/opentelemetry-auto-psr16 v.0.0.2
open-telemetry/opentelemetry-auto-wordpress v.0.0.15
open-telemetry/opentelemetry-auto-yii v.0.0.4

codecov · 2024-06-18T23:20:32Z

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (ac524f9) to head (284117b).
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
- Coverage     83.53%   82.65%   -0.88%     
+ Complexity     1057      997      -60     
============================================
  Files           104       97       -7     
  Lines          4392     4025     -367     
============================================
- Hits           3669     3327     -342     
+ Misses          723      698      -25

Flag	Coverage Δ
Aws:7.4	`?`
Aws:8.0	`85.75% <ø> (ø)`
Aws:8.1	`?`
Aws:8.2	`85.75% <ø> (ø)`
Aws:8.3	`?`
Context/Swoole:7.4	`0.00% <ø> (ø)`
Context/Swoole:8.0	`0.00% <ø> (ø)`
Context/Swoole:8.1	`0.00% <ø> (ø)`
Context/Swoole:8.2	`?`
Context/Swoole:8.3	`?`
Instrumentation/CakePHP:8.0	`?`
Instrumentation/CakePHP:8.1	`?`
Instrumentation/CakePHP:8.2	`?`
Instrumentation/CakePHP:8.3	`87.75% <0.00%> (-5.73%)`	⬇️
Instrumentation/CodeIgniter:8.0	`?`
Instrumentation/CodeIgniter:8.1	`?`
Instrumentation/CodeIgniter:8.2	`?`
Instrumentation/CodeIgniter:8.3	`73.94% <0.00%> (-1.92%)`	⬇️
Instrumentation/ExtAmqp:8.2	`89.58% <0.00%> (ø)`
Instrumentation/ExtAmqp:8.3	`89.58% <0.00%> (ø)`
Instrumentation/Guzzle:8.0	`?`
Instrumentation/Guzzle:8.1	`?`
Instrumentation/Guzzle:8.2	`?`
Instrumentation/Guzzle:8.3	`?`
Instrumentation/HttpAsyncClient:8.0	`?`
Instrumentation/HttpAsyncClient:8.1	`?`
Instrumentation/HttpAsyncClient:8.2	`?`
Instrumentation/HttpAsyncClient:8.3	`?`
Instrumentation/IO:8.2	`?`
Instrumentation/IO:8.3	`?`
Instrumentation/Laravel:8.0	`?`
Instrumentation/Laravel:8.1	`64.86% <0.00%> (-0.35%)`	⬇️
Instrumentation/Laravel:8.2	`64.86% <0.00%> (-0.35%)`	⬇️
Instrumentation/Laravel:8.3	`64.86% <0.00%> (-0.35%)`	⬇️
Instrumentation/MongoDB:7.4	`?`
Instrumentation/MongoDB:8.0	`?`
Instrumentation/MongoDB:8.1	`?`
Instrumentation/MongoDB:8.2	`77.33% <0.00%> (-3.23%)`	⬇️
Instrumentation/MongoDB:8.3	`77.33% <0.00%> (-3.23%)`	⬇️
Instrumentation/OpenAIPHP:8.1	`86.82% <100.00%> (ø)`
Instrumentation/OpenAIPHP:8.2	`?`
Instrumentation/OpenAIPHP:8.3	`?`
Instrumentation/PDO:8.2	`?`
Instrumentation/PDO:8.3	`?`
Instrumentation/Psr14:8.0	`?`
Instrumentation/Psr14:8.1	`78.12% <0.00%> (-2.53%)`	⬇️
Instrumentation/Psr14:8.2	`?`
Instrumentation/Psr14:8.3	`?`
Instrumentation/Psr15:8.0	`?`
Instrumentation/Psr15:8.1	`93.50% <ø> (ø)`
Instrumentation/Psr15:8.2	`93.50% <ø> (ø)`
Instrumentation/Psr15:8.3	`?`
Instrumentation/Psr16:8.0	`97.50% <100.00%> (ø)`
Instrumentation/Psr16:8.1	`?`
Instrumentation/Psr16:8.2	`?`
Instrumentation/Psr16:8.3	`97.50% <100.00%> (ø)`
Instrumentation/Psr18:8.0	`?`
Instrumentation/Psr18:8.1	`82.08% <ø> (ø)`
Instrumentation/Psr18:8.2	`82.08% <ø> (ø)`
Instrumentation/Psr18:8.3	`?`
Instrumentation/Psr3:8.0	`?`
Instrumentation/Psr3:8.1	`?`
Instrumentation/Psr3:8.2	`61.03% <0.00%> (-2.48%)`	⬇️
Instrumentation/Psr3:8.3	`?`
Instrumentation/Psr6:8.0	`?`
Instrumentation/Psr6:8.1	`?`
Instrumentation/Psr6:8.2	`97.61% <100.00%> (ø)`
Instrumentation/Psr6:8.3	`97.61% <100.00%> (ø)`
Instrumentation/Slim:8.0	`?`
Instrumentation/Slim:8.1	`?`
Instrumentation/Slim:8.2	`86.95% <ø> (ø)`
Instrumentation/Slim:8.3	`?`
Instrumentation/Symfony:8.0	`?`
Instrumentation/Symfony:8.1	`?`
Instrumentation/Symfony:8.2	`?`
Instrumentation/Symfony:8.3	`92.55% <ø> (-2.29%)`	⬇️
Instrumentation/Yii:8.0	`?`
Instrumentation/Yii:8.1	`?`
Instrumentation/Yii:8.2	`?`
Instrumentation/Yii:8.3	`77.77% <0.00%> (-2.05%)`	⬇️
Logs/Monolog:7.4	`?`
Logs/Monolog:8.0	`?`
Logs/Monolog:8.1	`?`
Logs/Monolog:8.2	`100.00% <ø> (ø)`
Logs/Monolog:8.3	`100.00% <ø> (ø)`
Propagation/ServerTiming:8.0	`?`
Propagation/ServerTiming:8.1	`?`
Propagation/ServerTiming:8.2	`100.00% <ø> (ø)`
Propagation/ServerTiming:8.3	`100.00% <ø> (ø)`
Propagation/TraceResponse:7.4	`100.00% <ø> (ø)`
Propagation/TraceResponse:8.0	`?`
Propagation/TraceResponse:8.1	`100.00% <ø> (ø)`
Propagation/TraceResponse:8.2	`?`
Propagation/TraceResponse:8.3	`?`
ResourceDetectors/Azure:7.4	`?`
ResourceDetectors/Azure:8.0	`?`
ResourceDetectors/Azure:8.1	`?`
ResourceDetectors/Azure:8.2	`91.66% <ø> (ø)`
ResourceDetectors/Azure:8.3	`91.66% <ø> (ø)`
ResourceDetectors/Container:8.0	`93.02% <ø> (ø)`
ResourceDetectors/Container:8.1	`?`
ResourceDetectors/Container:8.2	`?`
ResourceDetectors/Container:8.3	`93.02% <ø> (ø)`
Shims/OpenTracing:7.4	`?`
Shims/OpenTracing:8.0	`?`
Shims/OpenTracing:8.1	`?`
Shims/OpenTracing:8.2	`92.99% <ø> (ø)`
Shims/OpenTracing:8.3	`?`
Symfony:7.4	`88.43% <ø> (ø)`
Symfony:8.0	`88.20% <ø> (ø)`
Symfony:8.1	`?`
Symfony:8.2	`88.20% <ø> (ø)`
Symfony:8.3	`88.20% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ntation/OpenAIPHP/src/OpenAIPHPInstrumentation.php	`86.82% <100.00%> (ø)`
...Instrumentation/Psr16/src/Psr16Instrumentation.php	`97.50% <100.00%> (ø)`
...c/Instrumentation/Psr6/src/Psr6Instrumentation.php	`97.61% <100.00%> (ø)`
...rumentation/ExtAmqp/src/ExtAmqpInstrumentation.php	`89.58% <0.00%> (ø)`
...Instrumentation/Psr14/src/Psr14Instrumentation.php	`78.12% <0.00%> (-2.53%)`	⬇️
...rumentation/CakePHP/src/CakePHPInstrumentation.php	`87.75% <0.00%> (-5.73%)`	⬇️
...ion/CodeIgniter/src/CodeIgniterInstrumentation.php	`79.04% <0.00%> (-2.33%)`	⬇️
...rumentation/Laravel/src/LaravelInstrumentation.php	`0.00% <0.00%> (ø)`
...rumentation/MongoDB/src/MongoDBInstrumentation.php	`22.22% <0.00%> (-11.12%)`	⬇️
...c/Instrumentation/Psr3/src/Psr3Instrumentation.php	`49.15% <0.00%> (-2.64%)`	⬇️
... and 1 more

... and 9 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac524f9...284117b. Read the comment docs.

src/Instrumentation/Laravel/src/LaravelInstrumentation.php

brettmc · 2024-06-21T01:25:05Z

I had understood in open-telemetry/opentelemetry-php#1312 (comment) that we should update to the latest semantic version which is currently 1.25.

I did say latest in that comment, but in a subsequent discussion (it might have been at SIG), we decided that we should favour getting a 1.0 release of all auto-instrumentation modules with 8.0 support, if possible. Going with semconv 1.25 would block 8.0.

weslenteche · 2024-06-22T00:19:42Z

I did say latest in that comment, but in a subsequent discussion (it might have been at SIG), we decided that we should favour getting a 1.0 release of all auto-instrumentation modules with 8.0 support, if possible. Going with semconv 1.25 would block 8.0.

Thank you for clarifying my doubt

brettmc · 2024-06-22T00:24:35Z

LGTM 👍

weslenteche added 5 commits June 16, 2024 09:38

update semconv

e8d8523

add schema url

365be63

update composer

14ee00d

update composer

e661701

Merge remote-tracking branch 'origin/main' into add-schema-url

0df881f

ChrisLightfootWild reviewed Jun 19, 2024

View reviewed changes

src/Instrumentation/Laravel/src/LaravelInstrumentation.php Outdated Show resolved Hide resolved

weslenteche added 2 commits June 21, 2024 20:46

add schema url 1.24

0e9042f

update unit tests psr3

284117b

weslenteche marked this pull request as ready for review June 22, 2024 12:45

weslenteche requested review from a team and ChrisLightfootWild June 22, 2024 12:45

brettmc approved these changes Jun 23, 2024

View reviewed changes

ChrisLightfootWild approved these changes Jun 24, 2024

View reviewed changes

brettmc merged commit c937e29 into open-telemetry:main Jun 25, 2024

weslenteche deleted the add-schema-url branch June 25, 2024 23:40

weslenteche mentioned this pull request Jul 16, 2024

More signals for cakephp auto instrumentation #274

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added schema URL for all packages lower than 1.0.0 #273

Added schema URL for all packages lower than 1.0.0 #273

Uh oh!

weslenteche commented Jun 18, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jun 18, 2024 •

edited

Loading

Uh oh!

Uh oh!

brettmc commented Jun 21, 2024

Uh oh!

weslenteche commented Jun 22, 2024

Uh oh!

brettmc commented Jun 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Added schema URL for all packages lower than 1.0.0 #273

Added schema URL for all packages lower than 1.0.0 #273

Uh oh!

Conversation

weslenteche commented Jun 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

brettmc commented Jun 21, 2024

Uh oh!

weslenteche commented Jun 22, 2024

Uh oh!

brettmc commented Jun 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

weslenteche commented Jun 18, 2024 •

edited

Loading

codecov bot commented Jun 18, 2024 •

edited

Loading