fixing build failures #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CodeIgniter tests only pass against 4.4, so update minimum (with a case insensitivity change to test) - MongoDB using a now-deprecated semconv, which can be removed (we already have the suggested replacement) - Psr16 using an old version of psalm - adding missing phan config for ServerTiming and Container detector - adding update-lowest and all-lowest Make targets to run tests against lowest installable dependencies - remove deprecated docker-compose.version - update Dockerfile to use the core one, with some contrib additions (opentelemetry, mongo)
they use non-7.4-compatible syntax
ChrisLightfootWild
approved these changes
Apr 18, 2024
Contributor
ChrisLightfootWild
left a comment
ChrisLightfootWild
left a comment
There was a problem hiding this comment.
Nice!
I will fix any Laravel ones in my branch once this is merged 👍
bobstrecansky
approved these changes
Apr 18, 2024
Contributor
|
Looks like the only thing left here is @ChrisLightfootWild's Laravel tests that will get fixed subsequently. Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've left Laravel's phan complaints, because I think Chris might be working on it.