Fix PHPStan+Slim and Psalm+MongoDB+PHP 8.3 #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
============================================
- Coverage 85.33% 85.17% -0.16%
- Complexity 945 978 +33
============================================
Files 86 89 +3
Lines 3804 3939 +135
============================================
+ Hits 3246 3355 +109
- Misses 558 584 +26
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brettmc
approved these changes
Apr 3, 2024
brettmc
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with Psalm for MongoDB + PHP 8.3. MongoDB is the only package running Psalm at error level 1, and recently a new
MissingClassConstTypeissue was added to Psalm which gets triggered if error level is set to below 3. Since type declaration support for class constants were added in 8.3 and MongoDB package supports lower PHP versions, this issue cannot be fixed in code, so suppressing it via XML instead.Fixed an issue with PHPStan for Slim. It had an ignore rule for a falsely detected error that no longer happens either due to fixes to the latest minor/patch versions of PHPStan itself or Mockery. Ignore rules that were not actually triggered caused CI failure, so removed that ignore rule.