Skip to content

implement response propagation for Slim framework#247

Merged
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
brettmc:slim-response-propagation
Mar 19, 2024
Merged

implement response propagation for Slim framework#247
bobstrecansky merged 1 commit into
open-telemetry:mainfrom
brettmc:slim-response-propagation

Conversation

@brettmc

@brettmc brettmc commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

the functionality relies on a bug-fix in the extension from 1.0.2beta2

the functionality relies on a bug-fix in the extension from 1.0.2beta2
@brettmc
brettmc requested a review from a team March 19, 2024 02:24
@codecov

codecov Bot commented Mar 19, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 16.66667% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (1e30145) to head (4779ce2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #247      +/-   ##
============================================
- Coverage     85.47%   85.17%   -0.30%     
- Complexity      972      978       +6     
============================================
  Files            88       89       +1     
  Lines          3923     3939      +16     
============================================
+ Hits           3353     3355       +2     
- Misses          570      584      +14     
Flag Coverage Δ
7.4 85.72% <ø> (ø)
8.0 84.27% <16.66%> (-0.34%) ⬇️
8.1 84.39% <16.66%> (-0.33%) ⬇️
8.2 85.09% <16.66%> (-0.30%) ⬇️
8.3 85.09% <16.66%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...entation/Slim/src/PsrResponsePropagationSetter.php 0.00% <0.00%> (ø)
...c/Instrumentation/Slim/src/SlimInstrumentation.php 83.50% <27.27%> (-6.27%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e30145...4779ce2. Read the comment docs.

@bobstrecansky
bobstrecansky merged commit a91cca7 into open-telemetry:main Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants