Add PHP 8.3 to test matrix#245
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=========================================
Coverage 85.47% 85.47%
Complexity 972 972
=========================================
Files 88 88
Lines 3923 3923
=========================================
Hits 3353 3353
Misses 570 570
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
agoallikmaa
marked this pull request as ready for review
March 11, 2024 07:31
bobstrecansky
approved these changes
Mar 11, 2024
brettmc
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PHP 8.3 to test matrix. Did not test everything locally on 8.3 beforehand, so will keep as draft until any issues revealed by CI are fixed.
Updated psalm as the previous version of either psalm itself or its phpunit plugin did not support 8.3. This required some adjustment of psalm rules in some code.