Skip to content

[auto-ext-amqp] Require correct version for composer runtime package#224

Merged
brettmc merged 1 commit into
open-telemetry:mainfrom
xvilo:require-composer-runtime-api-2
Dec 12, 2023
Merged

[auto-ext-amqp] Require correct version for composer runtime package#224
brettmc merged 1 commit into
open-telemetry:mainfrom
xvilo:require-composer-runtime-api-2

Conversation

@xvilo

@xvilo xvilo commented Dec 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is required to access \Composer\InstalledVersions::getVersion() method. Docblock also clearly states this:

<?php

namespace Composer;

use Composer\Autoload\ClassLoader;
use Composer\Semver\VersionParser;

/**
 * This class is copied in every Composer installed project and available to all
 *
 * See also https://getcomposer.org/doc/07-runtime.md#installed-versions
 *
 * To require its presence, you can require `composer-runtime-api ^2.0`
 *
 * @final
 */
class InstalledVersions 
{ 
    // ...
}

Noted in #222 (comment)

@xvilo
xvilo requested a review from a team December 12, 2023 11:46
@xvilo xvilo changed the title Require the composer-runtime-api:2.0 package ]Require correct version for composer runtime package Dec 12, 2023
@xvilo xvilo changed the title ]Require correct version for composer runtime package [auto-ext-amqp] Require correct version for composer runtime package Dec 12, 2023
@codecov

codecov Bot commented Dec 12, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #224 (5255a29) into main (e3d1702) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #224   +/-   ##
=========================================
  Coverage     86.13%   86.13%           
  Complexity      905      905           
=========================================
  Files            82       82           
  Lines          3642     3642           
=========================================
  Hits           3137     3137           
  Misses          505      505
Flag Coverage Δ
7.4 85.63% <ø> (ø)
8.0 85.40% <ø> (ø)
8.1 85.43% <ø> (ø)
8.2 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d1702...5255a29. Read the comment docs.

@xvilo xvilo mentioned this pull request Dec 12, 2023
Merged
@xvilo
Require the composer-runtime-api:2.0 package
5255a29 
This is required to access  method
@xvilo
xvilo force-pushed the require-composer-runtime-api-2 branch from 51177dd to 5255a29 Compare December 12, 2023 11:48
@brettmc
brettmc merged commit 5ff4274 into open-telemetry:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettmc brettmc brettmc approved these changes
@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xvilo @brettmc @ChrisLightfootWild