http server semconv 1.23 updates#208
Merged
Merged
Conversation
brettmc
commented
Nov 8, 2023
brettmc
commented
Contributor
- update http server span names to match spec ("GET" or "GET "), per https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md#name
- adding http client/server span attributes
- do not normalize hyphen to underscore for http request/response header key, per https://opentelemetry.io/blog/2023/http-conventions-declared-stable/#common-attributes-across-http-client-and-server-spans
* update http server span names to match spec ("GET" or "GET <route>"), per https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md#name
* adding http client/server span attributes
* do not normalize hyphen to underscore for http request/response header key, per https://opentelemetry.io/blog/2023/http-conventions-declared-stable/#common-attributes-across-http-client-and-server-spans
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
============================================
- Coverage 33.12% 33.09% -0.04%
+ Complexity 852 851 -1
============================================
Files 76 76
Lines 3248 3251 +3
============================================
Hits 1076 1076
- Misses 2172 2175 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pdelewski
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.