Skip to content

Conversation

@brettmc
Copy link
Contributor

@brettmc brettmc commented Sep 18, 2023

if platform requirements are ignored, then trying to load this module causes a fatal error. that's particularly bad because it happens during composer autoloading, so add an extra check and do not try to run without the extension.

if platform requirements are ignored, then trying to load this module causes a fatal error.
that's particularly bad because it happens during composer autoloading, so add an extra
check and do not try to run without the extension.
@brettmc brettmc requested a review from a team September 18, 2023 03:51
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #194 (496bd72) into main (c8e79a8) will increase coverage by 6.26%.
Report is 2 commits behind head on main.
The diff coverage is 92.30%.

❗ Current head 496bd72 differs from pull request most recent head 7fd2cb1. Consider uploading reports for the commit 7fd2cb1 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #194      +/-   ##
============================================
+ Coverage     28.60%   34.86%   +6.26%     
- Complexity      472      816     +344     
============================================
  Files            47       71      +24     
  Lines          1755     3086    +1331     
============================================
+ Hits            502     1076     +574     
- Misses         1253     2010     +757     
Flag Coverage Δ
7.4 46.34% <92.30%> (-5.96%) ⬇️
8.0 34.94% <92.30%> (+7.07%) ⬆️
8.1 34.97% <92.30%> (+7.04%) ⬆️
8.2 34.81% <92.30%> (+6.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
src/ResourceDetectors/Container/src/Container.php 92.30%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e79a8...7fd2cb1. Read the comment docs.

@brettmc brettmc merged commit e19259f into open-telemetry:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants