Continuation of #170 #185
Continuation of #170 #185
Conversation
Signed-off-by: Natsuki Ikeguchi <[email protected]>
Signed-off-by: Natsuki Ikeguchi <[email protected]>
Signed-off-by: Natsuki Ikeguchi <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
============================================
- Coverage 34.83% 34.73% -0.11%
- Complexity 791 814 +23
============================================
Files 70 71 +1
Lines 3017 3078 +61
============================================
+ Hits 1051 1069 +18
- Misses 1966 2009 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
LGTM, thanks @siketyan for finishing off this work. Can you confirm that you've tested it against Laravel 6.x and it worked as expected? |
|
@brettmc I've confirmed that works as expected. 
composer.json: {
...snip,
"repositories": [
{
"type": "path",
"url": "../../github.com/yumemi-inc/opentelemetry-php-contrib/src/Instrumentation/Laravel"
}
],
"require": {
"php": "^7.2.5|^8.0",
"fideloper/proxy": "^4.4",
"laravel/framework": "^6.20.26",
"laravel/tinker": "^2.5",
"open-telemetry/exporter-otlp": "^1.0@beta",
"open-telemetry/opentelemetry": "^1.0@beta",
"open-telemetry/opentelemetry-auto-laravel": "dev-bug-fix-laravel-request-host",
"open-telemetry/sdk": "^1.0@beta",
"open-telemetry/transport-grpc": "^1.0@beta"
},
...snip
}command line: OTEL_PHP_AUTOLOAD_ENABLED=true \
OTEL_SERVICE_NAME=otel-laravel-app \
OTEL_TRACES_EXPORTER=otlp \
OTEL_EXPORTER_OTLP_PROTOCOL=grpc \
OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4317 \
OTEL_PROPAGATORS=baggage,tracecontext \
php artisan serve |
3 participants
This pull request continues #170.
Replaces #170