Adds fallback support for get host name method for all laravel versions #170
Conversation
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
============================================
- Coverage 40.76% 6.26% -34.50%
+ Complexity 313 199 -114
============================================
Files 28 20 -8
Lines 969 766 -203
============================================
- Hits 395 48 -347
- Misses 574 718 +144
Flags with carried forward coverage won't be shown. Click here to find out more. see 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Hi @abhisheksurve45 thanks for your contribution. This looks ok to me. Could you please also update |
@brettmc Added the same. |
|
@abhisheksurve45 confirming that you tested it against Laravel v6 and it worked (or at least didn't obviously fail!) |
Yes, have tested with Laravel ^6.0 @brettmc |
|
@abhisheksurve45 can you look into why the build is failing? It looks like it is trying to only install ^6, and cannot resolve dependencies. It should preferentially install v10 (latest stable) |
|
@abhisheksurve45 - are you blocked on this PR? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing, superceded by #185 |
3 participants
Fixes open-telemetry/opentelemetry-php#1045
First checks if
$request->host()(introduced in Illuminate Request 9.x ) method exists, if yes then calls it to get the host name else fall back to$request->getHost()method else returnsnull