adding baggage setValue and removeValue, plus example usage#888
Conversation
setValue and removeValue were added to spec after our initial baggage implementation, so implement the missing features. ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/baggage/api.md#set-value ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/baggage/api.md#remove-value
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=========================================
Coverage 81.56% 81.56%
Complexity 2008 2008
=========================================
Files 264 264
Lines 5219 5219
=========================================
Hits 4257 4257
Misses 962 962
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
I don't think we need this - functionality is already available via |
Seems you are right as specification gives some freedom how and where this functionality has to be provided.
|
toBaggageBuilder() can be used to achieve this, so update the example to do this
4 participants
setValue and removeValue were added to spec after our initial baggage implementation, so implement the missing features.
ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/baggage/api.md#set-value
ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/baggage/api.md#remove-value