Run exports with the Context the SpanProcessor was created in#880
Merged
bobstrecansky merged 2 commits intoDec 2, 2022
Merged
Conversation
Contributor
|
I tested this out, it works for me - exporter requests are no longer instrumented. I can see that the instrumentation handler |
Nevay
marked this pull request as ready for review
December 2, 2022 13:46
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
============================================
+ Coverage 81.21% 81.23% +0.02%
Complexity 2008 2008
============================================
Files 264 264
Lines 5212 5218 +6
============================================
+ Hits 4233 4239 +6
Misses 979 979
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #878.
(Matches the behavior of async implementations that create the export fiber in the constructor, example).