Skip to content

tests and benchmark for baggage parsing#873

Merged
brettmc merged 2 commits into
open-telemetry:mainfrom
brettmc:baggage-parser
Nov 29, 2022
Merged

tests and benchmark for baggage parsing#873
brettmc merged 2 commits into
open-telemetry:mainfrom
brettmc:baggage-parser

Conversation

@brettmc

@brettmc brettmc commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Closes #447

@brettmc
brettmc requested a review from a team November 28, 2022 05:22
@codecov

codecov Bot commented Nov 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #873 (e1bf8f1) into main (904da75) will increase coverage by 0.48%.
The diff coverage is 0.00%.

❗ Current head e1bf8f1 differs from pull request most recent head 9ea88e6. Consider uploading reports for the commit 9ea88e6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #873      +/-   ##
============================================
+ Coverage     79.81%   80.29%   +0.48%     
+ Complexity     2035     2034       -1     
============================================
  Files           268      268              
  Lines          5271     5269       -2     
============================================
+ Hits           4207     4231      +24     
+ Misses         1064     1038      -26     
Flag Coverage Δ
7.4 79.79% <0.00%> (+0.48%) ⬆️
8.0 80.29% <0.00%> (+0.48%) ⬆️
8.1 80.43% <0.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Baggage/Metadata.php 0.00% <0.00%> (ø)
src/API/Baggage/Propagation/Parser.php 100.00% <ø> (+100.00%) ⬆️
src/Context/Context.php 82.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904da75...9ea88e6. Read the comment docs.

Comment thread tests/Unit/API/Baggage/Propagation/ParserTest.php
@brettmc
brettmc merged commit 17f2fac into open-telemetry:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize baggage header parsing logic

3 participants