sdk autoloading#854
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
============================================
- Coverage 81.25% 80.67% -0.59%
- Complexity 1971 2011 +40
============================================
Files 250 255 +5
Lines 5165 5279 +114
============================================
+ Hits 4197 4259 +62
- Misses 968 1020 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
commented
Nov 2, 2022
brettmc
commented
Nov 2, 2022
brettmc
commented
Nov 2, 2022
Nevay
reviewed
Nov 2, 2022
Contributor
Author
|
This should wait for #859; it will need to incorporate config changes from that PR |
brettmc
marked this pull request as ready for review
November 7, 2022 02:23
bobstrecansky
approved these changes
Nov 11, 2022
Nevay
reviewed
Nov 11, 2022
ensure all user-provided defaults are of the correct type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable autoloading/creating a global SDK from environment variables, which can be used by auto-instrumentation.
This should allow auto-instrumentation without any code (with env vars). Note the addition of a new env var,
OTEL_PHP_AUTOLOAD_ENABLED- it must be enabled to allow autoloading.