Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

IMO we should drop the trait and use Accessor directly.

I agree, generally the trait doesn't add anything other than passing arguments on to the Accessor, besides a couple cases where it's coercing types to be what's "expected". Accessor appears to want strings always.

Example:
Accessor::getFloat expects a string default value
EnvironmentVariablesTrait::getFloatFromEnvironment expects a float for the default value

When it comes to entirely static traits though, the benefits of this type of mixin behavior are somewhat lost. A single EnvironmentVariables class with static methods would instead provide all of these things- unless it's consumed as part of the public API directly such that Sdk should have public methods for retrieving environment variables.

So options:

1. Make the trait's methods static
2. Remove EnvironmentVariablesTrait entirely
3. Provide a more friendly-typed EnvironmentVariables class with static methods

The largest impact in my opinion on this is whether anything using the trait does so not for internal private access, but public APIs. Namely, Sdk uses this trait, and it may be expected that those methods exist, which provide more friendly types (the EnvironmentVariablesTrait methods) and environment variable lookup behavior (the underlying Accessor).

I'm in favour of option 3 - it doesn't need to be a trait, and I appreciate the typing and self-documenting that a class such as EnvironmentVariables would give.
I'm not aware of any code outside of our own which might be accessing env vars, but I could imagine 3rd party -contrib code could do in future.

Codecov Report

Merging #850 (d8189f1) into main (f677757) will decrease coverage by 0.05%.
The diff coverage is 86.56%.

@@             Coverage Diff              @@
##               main     #850      +/-   ##
============================================
- Coverage     81.75%   81.69%   -0.06%     
+ Complexity     1947     1946       -1     
============================================
  Files           243      241       -2     
  Lines          5069     5080      +11     
============================================
+ Hits           4144     4150       +6     
- Misses          925      930       +5