Skip to content

Add support for global instrumentation initializer#849

Merged
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
Nevay:feature/instrumentation-initializer
Oct 26, 2022
Merged

Add support for global instrumentation initializer#849
bobstrecansky merged 2 commits into
open-telemetry:mainfrom
Nevay:feature/instrumentation-initializer

Conversation

@Nevay

@Nevay Nevay commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #849 (b31c532) into main (f677757) will increase coverage by 0.00%.
The diff coverage is 83.87%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #849   +/-   ##
=========================================
  Coverage     81.75%   81.75%           
- Complexity     1947     1954    +7     
=========================================
  Files           243      243           
  Lines          5069     5097   +28     
=========================================
+ Hits           4144     4167   +23     
- Misses          925      930    +5     
Flag Coverage Δ
7.4 81.23% <83.87%> (+<0.01%) ⬆️
8.0 81.75% <83.87%> (+<0.01%) ⬆️
8.1 81.89% <83.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/API/Common/Instrumentation/Globals.php 82.75% <80.76%> (-17.25%) ⬇️
src/API/Common/Instrumentation/Configurator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f677757...b31c532. Read the comment docs.

@brettmc

brettmc commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

This looks good to me, do you want to mark it ready and we can try to integrate it with auto-instrumentation?

@Nevay
Nevay marked this pull request as ready for review October 25, 2022 17:24
@Nevay
Nevay requested a review from a team October 25, 2022 17:24
@bobstrecansky
bobstrecansky merged commit 32d04f6 into open-telemetry:main Oct 26, 2022
@Nevay Nevay mentioned this pull request Nov 2, 2022
@Nevay
Nevay deleted the feature/instrumentation-initializer branch April 19, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants