removing event dispatcher#848
Merged
bobstrecansky merged 2 commits intoOct 26, 2022
Merged
Conversation
discussed in SIG to remove this unused code. It was going to be infrastructure for emitting metrics from other parts of the code, but that's been done in a better way now.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
============================================
- Coverage 81.75% 81.69% -0.06%
+ Complexity 1947 1938 -9
============================================
Files 243 241 -2
Lines 5069 5053 -16
============================================
- Hits 4144 4128 -16
Misses 925 925
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discussed in SIG to remove this unused code. It was going to be infrastructure for emitting metrics from other parts of the code, but that's been done in a better way now.