Sdk builder#845
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
============================================
- Coverage 81.69% 80.90% -0.80%
- Complexity 1946 1973 +27
============================================
Files 241 246 +5
Lines 5080 5173 +93
============================================
+ Hits 4150 4185 +35
- Misses 930 988 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
commented
Oct 19, 2022
brettmc
marked this pull request as ready for review
October 25, 2022 02:22
tcarrio
reviewed
Oct 25, 2022
tcarrio
left a comment
tcarrio
left a comment
Contributor
There was a problem hiding this comment.
Mostly a vested citizen in the CNCF channel excited for the OTel PHP SDK. A couple things I noticed here that I thought I would comment on 🙂
Nevay
reviewed
Oct 25, 2022
bobstrecansky
approved these changes
Oct 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fluent SDK builder mechanism to create and configure a working SDK.
Closes #301