resolve deptrac baseline#844
Merged
bobstrecansky merged 2 commits intoOct 12, 2022
Merged
Conversation
Nevay found that an @internal annotation in NonRecordingSpan was the cause of the violation, so remove it.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
============================================
- Coverage 82.51% 81.43% -1.09%
- Complexity 1888 1924 +36
============================================
Files 234 239 +5
Lines 4908 4982 +74
============================================
+ Hits 4050 4057 +7
- Misses 858 925 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bobstrecansky
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nevay found that an @internal annotation in NonRecordingSpan was the cause of the violation, so remove it.
Closes #718