Rename AbstractSpan to Span for consistent access to static methods#824
Merged
brettmc merged 2 commits intoSep 14, 2022
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
============================================
- Coverage 82.58% 82.56% -0.02%
Complexity 1884 1884
============================================
Files 230 231 +1
Lines 4898 4899 +1
============================================
Hits 4045 4045
- Misses 853 854 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brettmc
requested changes
Sep 13, 2022
brettmc
left a comment
brettmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Can you please add a BC compatibility entry for this one, as it's likely to break a lot of user code.
Nevay
force-pushed
the
feature/rename-abstract-span-to-span
branch
from
September 14, 2022 17:14
78d0ba7 to
057d864
Compare
brettmc
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies access to static interface methods. Other API interfaces with static methods have a class without the
Interfacesuffix that provides an implementation, e.g.:Baggage::getCurrent(): BaggageInterfaceSpanContext::getInvalid(): SpanContextInterfaceI considered creating a
Spanclass that does not implementSpanInterfacebut disliked the idea of splitting the PHPDoc documentation in different classes.