Add interfaces for Context and ContextKey#820
Merged
Merged
Conversation
Nevay
commented
Sep 9, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
============================================
- Coverage 82.57% 82.54% -0.03%
+ Complexity 1884 1876 -8
============================================
Files 231 230 -1
Lines 4901 4887 -14
============================================
- Hits 4047 4034 -13
+ Misses 854 853 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nevay
marked this pull request as ready for review
September 9, 2022 20:50
Nevay
force-pushed
the
feature/context-interfaces
branch
from
September 10, 2022 09:58
091be0f to
78abd05
Compare
brettmc
reviewed
Sep 11, 2022
Nevay
force-pushed
the
feature/context-interfaces
branch
2 times, most recently
from
September 14, 2022 17:59
bb92785 to
196c60a
Compare
brettmc
approved these changes
Sep 14, 2022
brettmc
left a comment
brettmc
left a comment
Contributor
There was a problem hiding this comment.
approved, some conflicts to be resolved before we can merge
Nevay
force-pushed
the
feature/context-interfaces
branch
from
September 17, 2022 08:39
196c60a to
c767d9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #795.