Remove ScopeBound... example implementations#819
Merged
brettmc merged 1 commit intoSep 10, 2022
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
============================================
- Coverage 82.88% 82.80% -0.08%
+ Complexity 1829 1803 -26
============================================
Files 225 222 -3
Lines 4697 4653 -44
============================================
- Hits 3893 3853 -40
+ Misses 804 800 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nevay
added a commit
to Nevay/opentelemetry-php
that referenced
this pull request
Sep 9, 2022
Drop if open-telemetry#819 is merged first.
brettmc
approved these changes
Sep 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ScopeBound...classes to reduce the API surface.ScopeBoundCallable: Was intended for event loops. Event loop decorators should instead implement this in a way that fits the specific loop API the best with regard to avoiding unnecessary references to arguments and error handling.(The implementation was (mostly) sufficient for
react/event-loopbut shouldn't be used forrevolt/event-loop.)ScopeBoundPromise: Was only intended as very basic example implementation. An actual implementation has to hook into the specific promise implementation to capture the context of the initial promise.(I'm not sure how useful promise/future support is in general, there are scenarios where we cannot preserve the context association, e.g. when extracting/awaiting the value.)