Skip to content

Restructure contrib directory#793

Merged
brettmc merged 4 commits into
open-telemetry:mainfrom
sumit-158:restructure-contrib-dir
Aug 13, 2022
Merged

Restructure contrib directory#793
brettmc merged 4 commits into
open-telemetry:mainfrom
sumit-158:restructure-contrib-dir

Conversation

@sumit-158

Copy link
Copy Markdown
Contributor

Restructured the contrib unit test directory
fix: #769

@welcome

welcome Bot commented Aug 10, 2022

Copy link
Copy Markdown

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 10, 2022

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sumit-158 / name: Sumit Kashyap (3317ba1)

@brettmc

brettmc commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

Hi @sumit-158 and welcome aboard! Can you please fix up the conflicts on your PR? Otherwise, it looks good to me!

@sumit-158

Copy link
Copy Markdown
Contributor Author

Done! @brettmc

Comment thread tests/Unit/Contrib/Prometheus/PrometheusExporterTest.php Outdated
@brettmc

brettmc commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

Last thing is can you fix the linting error? (make all locally will run all checks)

@sumit-158

Copy link
Copy Markdown
Contributor Author

Its failing with this error
image

@brettmc

brettmc commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

There are instructions in the readme on how to set up your dev environment (specifically, you need to set up your .env file)

@sumit-158
sumit-158 requested a review from brettmc August 11, 2022 15:21
@sumit-158

Copy link
Copy Markdown
Contributor Author

Make all passes successfully locally

@codecov

codecov Bot commented Aug 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #793 (8b6f28b) into main (3ac64f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #793   +/-   ##
=========================================
  Coverage     80.40%   80.40%           
  Complexity     1765     1765           
=========================================
  Files           222      222           
  Lines          4516     4516           
=========================================
  Hits           3631     3631           
  Misses          885      885           
Flag Coverage Δ
7.4 80.40% <ø> (ø)
8.0 80.43% <ø> (ø)
8.1 80.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac64f6...8b6f28b. Read the comment docs.

@brettmc
brettmc merged commit d05ea65 into open-telemetry:main Aug 13, 2022
@sumit-158
sumit-158 deleted the restructure-contrib-dir branch August 13, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Class Names and Directory Structure of Contrib Unit Tests.

2 participants