Add support for concurrent exports#790
Merged
bobstrecansky merged 2 commits intoAug 10, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #790 +/- ##
============================================
- Coverage 79.52% 79.43% -0.10%
- Complexity 1405 1407 +2
============================================
Files 160 161 +1
Lines 3468 3472 +4
============================================
Hits 2758 2758
- Misses 710 714 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nevay
marked this pull request as ready for review
August 7, 2022 09:15
Nevay
requested review from
bobstrecansky,
brettmc,
tidal and
zsistla
as code owners
August 7, 2022 09:15
Contributor
|
Looks good to me. Futures look quite similar to Promises, I was going to ask why not use promises (esp given recent cancellation work), but I think I talked myself out of it. |
brettmc
approved these changes
Aug 7, 2022
bobstrecansky
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #788.